[Qualys VMDR] Fix duplicate fields in transform#16903
[Qualys VMDR] Fix duplicate fields in transform#16903moxarth-rathod merged 1 commit intoelastic:mainfrom
Conversation
moxarth-rathod
added
bugfix
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| - name: source | ||
| type: keyword |
There was a problem hiding this comment.
Just in case, this field was not reported as duplicated in https://buildkite.com/elastic/integrations/builds/36182#019b9848-4c98-49a8-8af1-fac140f6e491/L479
There was a problem hiding this comment.
This field is currently not supported. To avoid any potential confusion or unexpected behaviour, it would be good to remove it from the field definition.
There was a problem hiding this comment.
Can you elaborate on why we are removing this field? It seems to be present even in the DTD of new API: #16640 (comment)
Any field removal even if unsupported by the API should be a breaking-change.
There was a problem hiding this comment.
The pipeline currently does not parse this field. I initially planned to add it to the pipeline, but later removed it from the changes. However, I forgot to remove the field from the transform, so I now want to remove it for the time being.
There was a problem hiding this comment.
@moxarth-rathod, can you please add this context to the commit message?
There was a problem hiding this comment.
@moxarth-rathod, suggested commit:
qualys_vmdr: remove duplicate fields in transform as per the comment [1] in this PR [2].
Also, remove unsupported field `source` from the fields definition. The pipeline currently does not
parse this field. This was incorrectly added into the transform fields inside the PR [2].
- [1] https://github.com/elastic/integrations/pull/16727#issuecomment-3719541508
- [2] https://github.com/elastic/integrations/pull/16727
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
4 participants
Proposed commit message
Checklist
changelog.ymlfile.Related issues